Skip to content

Updating for release v1.0.3 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KristofferSkare wants to merge 3 commits into from
Closed

Updating for release v1.0.3 #93

KristofferSkare wants to merge 3 commits into from

Conversation

@KristofferSkare
Copy link
Collaborator

@KristofferSkare KristofferSkare commented Jun 16, 2025 •
edited by StephanieKemna
Loading

Description

Resolves #92

Updates version number and cahngelog for new version release.

How Has This Been Tested?

Screenshots (if appropriate)

Developer Checklist (before requesting PR review)

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

I have:

  • commented my code, particularly in hard-to-understand areas
  • performed a self-review of my own code
  • not committed unnecessary formatting changes, thereby occluding the actual changes (e.g. change of tab spacing, eol, etc.)
  • made corresponding changes to the documentation
  • added change to CHANGELOG.md
  • added tests that prove my fix is effective or that my feature works (for core features)

Reviewer checklist

I have:

  • performed a review of the code
  • tested that the software still works as expected
  • checked updates to documentation
  • checked that the CHANGELOG is updated

KristofferSkare
KristofferSkare commented Jun 16, 2025
View reviewed changes
StephanieKemna
StephanieKemna approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@StephanieKemna StephanieKemna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but see also other PR wrt bump-my-version, you can do a release via the release interface in GitHub then (presumably). Note there are currently issues with the python checkers, should be fixed before this can be merged (guess we got newer versions of ruff and pyright and such than before).

@KristofferSkare
Copy link
Collaborator Author

KristofferSkare commented Jun 18, 2025

Ok, but see also other PR wrt bump-my-version, you can do a release via the release interface in GitHub then (presumably). Note there are currently issues with the python checkers, should be fixed before this can be merged (guess we got newer versions of ruff and pyright and such than before).

Nice, I did look closely at that PR before opening this one. the better approach is to merge that one instead of this one. And then maybe only add the change to the python version to not include 3.13.

Only risk is that we are not quite sure if that PR #90 actually works, but I think that it is worth it to merge that one first and see if we are able to release with that instead of this PR.

@StephanieKemna
Copy link
Collaborator

StephanieKemna commented Jun 18, 2025

Ok, but see also other PR wrt bump-my-version, you can do a release via the release interface in GitHub then (presumably). Note there are currently issues with the python checkers, should be fixed before this can be merged (guess we got newer versions of ruff and pyright and such than before).

Nice, I did look closely at that PR before opening this one. the better approach is to merge that one instead of this one. And then maybe only add the change to the python version to not include 3.13.

Only risk is that we are not quite sure if that PR #90 actually works, but I think that it is worth it to merge that one first and see if we are able to release with that instead of this PR.

I am cherry-picking the python version restriction into enh/90-x branch, then will check/fix other formatting issues.

@StephanieKemna
Copy link
Collaborator

StephanieKemna commented Jun 25, 2025

Deprecated, see #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanieKemna StephanieKemna StephanieKemna approved these changes

@ClaasRostock ClaasRostock Awaiting requested review from ClaasRostock

Assignees

@KristofferSkare KristofferSkare

Labels

release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

time for new release version?

3 participants

@KristofferSkare @StephanieKemna